feat: remove pylint from strict dependencies; add [all] flag#37
Merged
Conversation
Closed
There was a problem hiding this comment.
Pull request overview
This PR adjusts QTMonaco’s Python dependency strategy to avoid pulling pylint in as a default transitive dependency via python-lsp-server[all], while adding a new qtmonaco[all] extra for users who explicitly want the full set of python-lsp-server plugins.
Changes:
- Replaces the core dependency on
python-lsp-server[all,websockets]with an explicit list ofpython-lsp-serverextras that excludespylint. - Adds a new optional dependency extra
allthat installspython-lsp-server[all,...]. - Updates README install commands to reference the new
allextra.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Updates installation instructions to include the new all extra. |
| pyproject.toml | Unwraps python-lsp-server[all] into explicit extras (excluding pylint) and introduces a project-level all optional extra. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wakonig
force-pushed
the
feature/build_without_pylint
branch
from
ff075e2 to
2a320d0
Compare
d-perl
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes pylint as strict dependency through
python-lsp-server[all]and instead moves it to an optional dependency.Related Issues
#36
Type of Change
python-lsp-server's [all] statement and skip pylintPotential side effects
pylint is not included anymore by default
Definition of Done